Skip to content

Filter out the special PXE boot parameters#2293

Merged
lslezak merged 2 commits intomasterfrom
clean_boot_params
Apr 25, 2025
Merged

Filter out the special PXE boot parameters#2293
lslezak merged 2 commits intomasterfrom
clean_boot_params

Conversation

@lslezak
Copy link
Copy Markdown
Contributor

@lslezak lslezak commented Apr 24, 2025 •
edited
Loading

Problem

Solution

  • Enhance the filtering code to ignore the specific PXE boot parameters
  • Remove also most of the network settings

Testing

  • The unit test has been updated
  • Tested manually

Screenshots

After booting the installer via PXE the extra parameters can be seen in the /proc/cmdline file. But the /run/agama/cmdline.d/kernel.conf does not include them and the journal log shows they were ignored:
agama-boot-params

After booting the installed system no PXE boot option is present on the linux line:
agama-boot-params-installed

@lslezak
Filter out the special PXE boot parameters
4ae6c60 
- Do not pass them to the installed system
- Remove also most of the network settings
- gh##2280
jreidinger
jreidinger reviewed Apr 24, 2025
View reviewed changes
Comment thread live/test/fixtures/expected/cmdline
@@ -1 +1 @@
BOOT_IMAGE=/boot/vmlinuz splash=silent mitigations=auto quiet nosimplefb=1 No newline at end of file
splash=silent mitigations=auto quiet nosimplefb=1 No newline at end of file
Copy link
Copy Markdown
Contributor

@jreidinger jreidinger Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, to be sure I would enhance test with various parameters we are using like some rd.kiwi params and some oh others which are more tricky to be sure that regexp matching

@lslezak
Copy link
Copy Markdown
Contributor Author

lslezak commented Apr 25, 2025

BTW using spaces in parameters does not work properly. e.g. initrd="/boot/ /initrd" is not processed correctly.

We use a simple shell word splitting functionality, for proper parsing we would need to write our full parser and process the input character by character. That's not trivial and then we would probably need to fix all code which uses the processed /run/agama/cmdline.d/kernel.conf file.

Using spaces or newlines in file names usually causes troubles. I'd keep it as it is and fix it only when we get a real use case for this scenario.

ancorgs
ancorgs approved these changes Apr 25, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@ancorgs ancorgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lslezak lslezak merged commit 3e5ac5d into master Apr 25, 2025
8 checks passed
@lslezak lslezak deleted the clean_boot_params branch April 25, 2025 13:09
@lslezak lslezak mentioned this pull request Apr 25, 2025
Closed
@imobachgs imobachgs mentioned this pull request May 26, 2025
Merged
imobachgs added a commit that referenced this pull request May 26, 2025
@imobachgs
Update to release 15 (#2405)
39bd0ec 
Prepare to release Agama 15:

* #2258
* #2270
* #2277
* #2279
* #2283
* #2284
* #2285
* #2286
* #2287
* #2288
* #2291
* #2292
* #2293
* #2295
* #2297
* #2299
* #2300
* #2301
* #2302
* #2303
* #2305
* #2306
* #2307
* #2308
* #2309
* #2313
* #2314
* #2315
* #2317
* #2318
* #2319
* #2320
* #2321
* #2322
* #2323
* #2324
* #2325
* #2328
* #2329
* #2330
* #2331
* #2335
* #2336
* #2337
* #2338
* #2339
* #2340
* #2342
* #2345
* #2346
* #2348
* #2349
* #2350
* #2351
* #2352
* #2353
* #2354
* #2355
* #2357
* #2358
* #2359
* #2360
* #2361
* #2362
* #2363
* #2364
* #2365
* #2366
* #2368
* #2369
* #2370
* #2371
* #2372
* #2374
* #2377
* #2378
* #2379
* #2380
* #2381
* #2382
* #2384
* #2385
* #2386
* #2388
* #2389
* #2390
* #2391
* #2392
* #2394
* #2397
* #2398
* #2401
* #2403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jreidinger jreidinger jreidinger left review comments

@ancorgs ancorgs ancorgs approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lslezak @jreidinger @ancorgs